[Compatibility] Added COMMAND GETKEYS and GETKEYSANDFLAGS command #888
Conversation
libs/server/Resp/BasicCommands.cs
Outdated
| return AbortWithErrorMessage(CmdStrings.RESP_COMMAND_HAS_NO_KEY_ARGS); | ||
| } | ||
|
|
||
| var keyList = new List<byte[]>(); |
There was a problem hiding this comment.
Why do we have to allocate a byte[] for each key? The keys already exist in the parse state.
There was a problem hiding this comment.
Technically you don't even need to allocate the list, the keys are always consecutive in the parse state, right? If so, you only need the first and last index of keys...
|
Fixed all review commands |
| @@ -1485,6 +1485,50 @@ | |||
| "ArgumentFlags": "Optional, Multiple" | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| "Command": "COMMAND_GETKEYS", | |||
There was a problem hiding this comment.
Same comment here about running CommentInfoUpdater - #864 (comment)
| /// <summary> | ||
| /// Extension methods for the SessionParseState struct. | ||
| /// </summary> | ||
| internal static class SessionParseStateExtension |
There was a problem hiding this comment.
These methods can be added to the existing Garnet.server/SessionParseStateExtensions.cs
| return true; | ||
| } | ||
|
|
||
| internal static bool TryExtractKeyandFlagsFromSpecs(this ref SessionParseState state, RespCommandKeySpecification[] keySpecs, out List<ArgSlice> keys, out List<string[]> flags) |
There was a problem hiding this comment.
naming: TryExtractKeysAndFlagsFromSpecs
| if (startIndex < 0 || startIndex >= state.Count) | ||
| return false; | ||
|
|
||
| if (spec.FindKeys is FindKeysRange range) |
There was a problem hiding this comment.
Instead of doing this type matching you can have ExtractKeys defined as an abstract method in FindKeysKeySpecMethodBase
| { | ||
| int startIndex = 0; | ||
|
|
||
| if (spec.BeginSearch is BeginSearchIndex bsIndex) |
There was a problem hiding this comment.
Here too, you can have an abstract method called GetStartIndex (or something similar) in BeginSearchKeySpecMethodBase that you can implement for each of the different types.
| @@ -263,6 +279,32 @@ public BeginSearchKeyword(string keyword, int startFrom) : this() | |||
| this.Keyword = keyword; | |||
| this.StartFrom = startFrom; | |||
| } | |||
|
|
|||
| public bool TryGetStartFrom(ref SessionParseState parseState, out int index) | |||
|
|
||
| // Determine the search direction | ||
| int increment = StartFrom < 0 ? -1 : 1; | ||
| int start = StartFrom < 0 ? searchStartIndex : searchStartIndex; |
| @@ -339,6 +381,35 @@ public FindKeysRange(int lastKey, int keyStep, int limit) : this() | |||
| this.KeyStep = keyStep; | |||
| this.Limit = limit; | |||
| } | |||
|
|
|||
| public void ExtractKeys(ref SessionParseState state, int startIndex, List<ArgSlice> keys) | |||
| @@ -385,6 +456,45 @@ public FindKeysKeyNum(int keyNumIdx, int firstKey, int keyStep) : this() | |||
| this.FirstKey = firstKey; | |||
| this.KeyStep = keyStep; | |||
| } | |||
|
|
|||
| public void ExtractKeys(ref SessionParseState state, int startIndex, List<ArgSlice> keys) | |||
| // Extract keys based on numKeys, firstKey, and keyStep | ||
| if (numKeys > 0 && firstKey >= 0) | ||
| { | ||
| for (int i = 0; i < numKeys && firstKey + i * KeyStep < state.Count; i++) |
There was a problem hiding this comment.
nit: Add parentheses around i * KeyStep for clarity (in the next line as well)
Adding the COMMAND GETKEYS and GETKEYSANDFLAGS command to garnet